Ticket #65 (closed Problem: fixed)

Opened 19 months ago

Last modified 19 months ago

notice.bro reports run-time errors when a remote connection goes away

Reported by: robin Owned by:
Priority: Normal Component: Bro
Version: 1.4 Keywords:
Cc:

Description (last modified by robin) (diff)

When a Broccoli client terminates the connection, remote.bro still accesses the list of clients with the now invalid client index. We need to add check for that.

From Craig:

1234639528.393567 run-time error: peer 10001 does not exist
1234639528.393567 /usr/local/bro/share/bro/notice.bro, line 261
(n$src_peer): internal error: field value missing

Attachments

peer-gone-fix.diff Download (442 bytes) - added by robin 19 months ago.

Change History

Changed 19 months ago by robin

  • status changed from new to seen
  • description modified (diff)

Changed 19 months ago by robin

Changed 19 months ago by robin

  • status changed from seen to needs information
  • description modified (diff)
  • summary changed from Remote.bro reports run-time errors when a remote connection goes away to notice.bro reports run-time errors when a remote connection goes away

I've attached a patch, which should fix the problem. It will still return the run-time error because that's what it is. :) Note that because we can't really return a dedicated error value, we now return the local peer val also in the case that the remote peer's connection has already terminated.

Changed 19 months ago by robin

  • status changed from needs information to closed
  • resolution set to fixed

(In [6601]) - Bugfix: Bro could crash when get_event_peer() was called after a

remote connection had already disppeared. Now it just prints a
runtime error in this case.


Closes #65.

Changed 19 months ago by robin

Patch filed in #70

Add/Change #65 (notice.bro reports run-time errors when a remote connection goes away)

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.